Changes `options` to always exist for mutability

src/plus/webviews/graph/graphWebview.ts

@@ -241,13 +241,13 @@ export class GraphWebviewProvider implements WebviewProvider {
 
 	async canShowWebviewPanel(
 		firstTime: boolean,
-		options?: { column?: ViewColumn; preserveFocus?: boolean },
+		options: { column?: ViewColumn; preserveFocus?: boolean },
 		...args: unknown[]
 	): Promise<boolean> {
 		this._firstSelection = true;
 		if (!(await ensurePlusFeaturesEnabled())) return false;
 
-		if (options?.column != null) {
+		if (options.column == null) {
 			options.column = ViewColumn.Active;
 		}
 

src/plus/webviews/timeline/timelineWebview.ts

@@ -83,7 +83,7 @@ export class TimelineWebviewProvider implements WebviewProvider {
 
 	async canShowWebviewPanel(
 		firstTime: boolean,
-		_options?: { column?: ViewColumn; preserveFocus?: boolean },
+		_options: { column?: ViewColumn; preserveFocus?: boolean },
 		...args: unknown[]
 	): Promise<boolean> {
 		if (!(await ensurePlusFeaturesEnabled())) return false;

src/webviews/home/homeWebview.ts

@@ -60,7 +60,7 @@ export class HomeWebviewProvider implements WebviewProvider {
 
 	async canShowWebviewPanel(
 		_firstTime: boolean,
-		_options?: { column?: ViewColumn; preserveFocus?: boolean },
+		_options: { column?: ViewColumn; preserveFocus?: boolean },
 		..._args: unknown[]
 	): Promise<boolean> {
 		if (!(await ensurePlusFeaturesEnabled())) return false;

src/webviews/webviewController.ts

@@ -36,14 +36,19 @@ function nextIpcId() {
 export interface WebviewProvider<State, SerializedState = State> extends Disposable {
 	canShowWebviewPanel?(
 		firstTime: boolean,
-		options?: { column?: ViewColumn; preserveFocus?: boolean },
+		options: { column?: ViewColumn; preserveFocus?: boolean },
 		...args: unknown[]
 	): boolean | Promise<boolean>;
 	onShowWebviewPanel?(
 		firstTime: boolean,
-		options?: { column?: ViewColumn; preserveFocus?: boolean },
+		options: { column?: ViewColumn; preserveFocus?: boolean },
 		...args: unknown[]
 	): void | Promise<void>;
+	canShowWebviewView?(
+		firstTime: boolean,
+		options: { column?: ViewColumn; preserveFocus?: boolean },
+		...args: unknown[]
+	): boolean | Promise<boolean>;
 	registerCommands?(): Disposable[];
 
 	includeBootstrap?(): SerializedState | Promise<SerializedState>;
@@ -212,6 +217,10 @@ export class WebviewController implements Dispos
 	}
 
 	async show(firstTime: boolean, options?: { column?: ViewColumn; preserveFocus?: boolean }, ...args: unknown[]) {
+		if (options == null) {
+			options = {};
+		}
+
 		if (this.isType('tab')) {
 			const result = await this.provider.canShowWebviewPanel?.(firstTime, options, ...args);
 			if (result === false) return;