From f20c1dc58b78c8b4abf35ffbd5cc546e14127219 Mon Sep 17 00:00:00 2001 From: Eric Amodio Date: Thu, 18 Aug 2022 01:39:34 -0400 Subject: [PATCH] Changes avatarUrl to avatarUri on RemoteProvider Removes avatarUrl from GitRemote (as it duplicates RemoteProvider) --- src/git/models/remote.ts | 1 - src/git/parsers/remoteParser.ts | 1 - src/git/remotes/github.ts | 14 +++++++------- src/git/remotes/provider.ts | 8 ++++---- src/plus/github/githubGitProvider.ts | 2 -- 5 files changed, 11 insertions(+), 15 deletions(-) diff --git a/src/git/models/remote.ts b/src/git/models/remote.ts index 6f5ffa9..a037e0c 100644 --- a/src/git/models/remote.ts +++ b/src/git/models/remote.ts @@ -56,7 +56,6 @@ export class GitRemote { if (!equalsIgnoreCase(this.domain, 'github.com')) { diff --git a/src/git/remotes/provider.ts b/src/git/remotes/provider.ts index 2f0994e..54b654c 100644 --- a/src/git/remotes/provider.ts +++ b/src/git/remotes/provider.ts @@ -121,6 +121,10 @@ export abstract class RemoteProvider implements RemoteProviderReference { return []; } + get avatarUri(): Uri | undefined { + return undefined; + } + get displayPath(): string { return this.path; } @@ -129,10 +133,6 @@ export abstract class RemoteProvider implements RemoteProviderReference { return 'remote'; } - get avatarUrl(): string | undefined { - return undefined; - } - abstract get id(): string; abstract get name(): string; diff --git a/src/plus/github/githubGitProvider.ts b/src/plus/github/githubGitProvider.ts index ecc6735..11a7c51 100644 --- a/src/plus/github/githubGitProvider.ts +++ b/src/plus/github/githubGitProvider.ts @@ -2145,7 +2145,6 @@ export class GitHubGitProvider implements GitProvider, Disposable { const url = `https://github.com/${owner}/${repo}.git`; const domain = 'github.com'; const path = `${owner}/${repo}`; - const avatarUrl = `https://avatars.githubusercontent.com/${owner}`; return [ new GitRemote( @@ -2160,7 +2159,6 @@ export class GitHubGitProvider implements GitProvider, Disposable { { type: GitRemoteType.Fetch, url: url }, { type: GitRemoteType.Push, url: url }, ], - avatarUrl, ), ]; }