Преглед изворни кода

Fixes finding view nodes if view isn't loaded yet

main
Eric Amodio пре 3 година
родитељ
комит
ef71c1850b
1 измењених фајлова са 22 додато и 18 уклоњено
  1. +22
    -18
      src/views/viewBase.ts

+ 22
- 18
src/views/viewBase.ts Прегледај датотеку

@ -349,26 +349,30 @@ export abstract class ViewBase<
): Promise<ViewNode | undefined> {
const cc = Logger.getCorrelationContext();
// If we have no root (e.g. never been initialized) force it so the tree will load properly
if (this.root == null) {
await this.show();
async function find(this: ViewBase<RootNode, ViewConfig>) {
try {
const node = await this.findNodeCoreBFS(
typeof predicate === 'string' ? n => n.id === predicate : predicate,
this.ensureRoot(),
allowPaging,
canTraverse,
maxDepth,
token,
);
return node;
} catch (ex) {
Logger.error(ex, cc);
return undefined;
}
}
try {
const node = await this.findNodeCoreBFS(
typeof predicate === 'string' ? n => n.id === predicate : predicate,
this.ensureRoot(),
allowPaging,
canTraverse,
maxDepth,
token,
);
return node;
} catch (ex) {
Logger.error(ex, cc);
return undefined;
}
if (this.root != null) return find.call(this);
// If we have no root (e.g. never been initialized) force it so the tree will load properly
await this.show();
// Since we have to show the view, let the callstack unwind before we try to find the node
return new Promise<ViewNode | undefined>(resolve => setTimeout(() => resolve(find.call(this)), 0));
}
private async findNodeCoreBFS(

Loading…
Откажи
Сачувај