Browse Source

Fixes #1645 - removes regex

Possible catastrophic backtracking with large inputs (very unlikely in the wild)
main
Eric Amodio 2 years ago
parent
commit
e417446f59
1 changed files with 2 additions and 6 deletions
  1. +2
    -6
      src/env/node/git/locator.ts

+ 2
- 6
src/env/node/git/locator.ts View File

@ -70,12 +70,8 @@ async function findSpecificGit(path: string): Promise {
async function findGitDarwin(): Promise<GitLocation> { async function findGitDarwin(): Promise<GitLocation> {
try { try {
let path = await run<string>('which', ['git'], 'utf8');
path = path.replace(/^\s+|\s+$/g, '');
if (path !== '/usr/bin/git') {
return findSpecificGit(path);
}
const path = (await run<string>('which', ['git'], 'utf8')).trim();
if (path !== '/usr/bin/git') return findSpecificGit(path);
try { try {
await run<string>('xcode-select', ['-p'], 'utf8'); await run<string>('xcode-select', ['-p'], 'utf8');

Loading…
Cancel
Save