From c007b15176fcf5308b8d1f24d47adc280be36e02 Mon Sep 17 00:00:00 2001 From: Keith Daulton Date: Wed, 24 Aug 2022 23:04:54 -0400 Subject: [PATCH] Updates commit graph status bar - adds feedback link - updates focus state colors - updates aria-activedescendant when viewing repos --- src/webviews/apps/plus/graph/GraphWrapper.tsx | 23 +++++++++++++++++------ src/webviews/apps/plus/graph/graph.scss | 10 ++++++++++ 2 files changed, 27 insertions(+), 6 deletions(-) diff --git a/src/webviews/apps/plus/graph/GraphWrapper.tsx b/src/webviews/apps/plus/graph/GraphWrapper.tsx index c4b5ba8..50ed5f8 100644 --- a/src/webviews/apps/plus/graph/GraphWrapper.tsx +++ b/src/webviews/apps/plus/graph/GraphWrapper.tsx @@ -274,7 +274,13 @@ export function GraphWrapper({ id="repo-actioncombo-label" className="actioncombo__label" role="combobox" - aria-activedescendant="" + aria-activedescendant={ + repoExpanded + ? `repo-actioncombo-item-${reposList.findIndex( + item => item.path === currentRepository?.path, + )}` + : undefined + } onClick={() => handleToggleRepos()} > @@ -304,14 +310,14 @@ export function GraphWrapper({ )) ) : ( -
  • None available -
  • + )} @@ -320,11 +326,16 @@ export function GraphWrapper({ {graphList.length} commit{graphList.length ? 's' : ''} )} - {isLoading && ( - - )} + {isLoading && }
    + + + {' '} Preview
    diff --git a/src/webviews/apps/plus/graph/graph.scss b/src/webviews/apps/plus/graph/graph.scss index 1c032f4..958b815 100644 --- a/src/webviews/apps/plus/graph/graph.scss +++ b/src/webviews/apps/plus/graph/graph.scss @@ -46,6 +46,15 @@ a { margin: 0; } } + + a { + color: inherit; + } + + :focus { + outline: 1px solid var(--vscode-focusBorder); + outline-offset: -1x; + } } .actioncombo { @@ -105,6 +114,7 @@ a { min-width: 100%; width: max-content; z-index: 100; + background-color: var(--actionbar-background-color); } &__label:not([aria-expanded='true']) + &__list {