Browse Source

Adds placeholder string to repo pickers

main
Eric Amodio 1 year ago
parent
commit
b032f658aa
2 changed files with 5 additions and 3 deletions
  1. +1
    -1
      src/commands/openAssociatedPullRequestOnRemote.ts
  2. +4
    -2
      src/quickpicks/repositoryPicker.ts

+ 1
- 1
src/commands/openAssociatedPullRequestOnRemote.ts View File

@ -40,7 +40,7 @@ export class OpenAssociatedPullRequestOnRemoteCommand extends ActiveEditorComman
} }
try { try {
const repo = await getRepositoryOrShowPicker('Open Pull Request Associated', undefined, {
const repo = await getRepositoryOrShowPicker('Open Pull Request Associated', undefined, undefined, {
filter: async r => (await this.container.git.getBestRemoteWithRichProvider(r.uri))?.provider != null, filter: async r => (await this.container.git.getBestRemoteWithRichProvider(r.uri))?.provider != null,
}); });
if (repo == null) return; if (repo == null) return;

+ 4
- 2
src/quickpicks/repositoryPicker.ts View File

@ -13,6 +13,7 @@ export async function getBestRepositoryOrShowPicker(
uri: Uri | undefined, uri: Uri | undefined,
editor: TextEditor | undefined, editor: TextEditor | undefined,
title: string, title: string,
placeholder?: string,
options?: { filter?: (r: Repository) => Promise<boolean> }, options?: { filter?: (r: Repository) => Promise<boolean> },
): Promise<Repository | undefined> { ): Promise<Repository | undefined> {
let repository = Container.instance.git.getBestRepository(uri, editor); let repository = Container.instance.git.getBestRepository(uri, editor);
@ -24,7 +25,7 @@ export async function getBestRepositoryOrShowPicker(
} }
if (repository != null) return repository; if (repository != null) return repository;
const pick = await showRepositoryPicker(title, undefined, options);
const pick = await showRepositoryPicker(title, placeholder, options);
if (pick instanceof CommandQuickPickItem) { if (pick instanceof CommandQuickPickItem) {
await pick.execute(); await pick.execute();
return undefined; return undefined;
@ -35,6 +36,7 @@ export async function getBestRepositoryOrShowPicker(
export async function getRepositoryOrShowPicker( export async function getRepositoryOrShowPicker(
title: string, title: string,
placeholder?: string,
uri?: Uri, uri?: Uri,
options?: { filter?: (r: Repository) => Promise<boolean> }, options?: { filter?: (r: Repository) => Promise<boolean> },
): Promise<Repository | undefined> { ): Promise<Repository | undefined> {
@ -52,7 +54,7 @@ export async function getRepositoryOrShowPicker(
} }
if (repository != null) return repository; if (repository != null) return repository;
const pick = await showRepositoryPicker(title, undefined, options);
const pick = await showRepositoryPicker(title, placeholder, options);
if (pick instanceof CommandQuickPickItem) { if (pick instanceof CommandQuickPickItem) {
void (await pick.execute()); void (await pick.execute());
return undefined; return undefined;

Loading…
Cancel
Save