Browse Source

Turns off prefer-nullish-coalescing lint rule

main
Eric Amodio 3 years ago
parent
commit
9aa755cf25
4 changed files with 1 additions and 7 deletions
  1. +1
    -1
      .eslintrc.json
  2. +0
    -1
      src/system/searchTree.ts
  3. +0
    -4
      src/views/nodes/compareBranchNode.ts
  4. +0
    -1
      webpack.config.js

+ 1
- 1
.eslintrc.json View File

@ -231,7 +231,7 @@
}
],
"@typescript-eslint/no-use-before-define": "off",
"@typescript-eslint/prefer-nullish-coalescing": "warn",
"@typescript-eslint/prefer-nullish-coalescing": "off",
"@typescript-eslint/prefer-optional-chain": "warn",
"@typescript-eslint/restrict-template-expressions": [
"error",

+ 0
- 1
src/system/searchTree.ts View File

@ -1,4 +1,3 @@
/* eslint-disable @typescript-eslint/prefer-nullish-coalescing */
/* eslint-disable @typescript-eslint/strict-boolean-expressions */
'use strict';
import { count, map, some } from './iterable';

+ 0
- 4
src/views/nodes/compareBranchNode.ts View File

@ -40,7 +40,6 @@ export class CompareBranchNode extends ViewNode
get ahead(): { readonly ref1: string; readonly ref2: string } {
return {
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
ref1: this._compareWith?.ref || 'HEAD',
ref2: this.branch.ref,
};
@ -49,7 +48,6 @@ export class CompareBranchNode extends ViewNode
get behind(): { readonly ref1: string; readonly ref2: string } {
return {
ref1: this.branch.ref,
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
ref2: this._compareWith?.ref || 'HEAD',
};
}
@ -241,7 +239,6 @@ export class CompareBranchNode extends ViewNode
private async getAheadFilesQuery(): Promise<FilesQueryResults> {
let files = await Container.git.getDiffStatus(
this.repoPath,
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
GitRevision.createRange(this._compareWith?.ref || 'HEAD', this.branch.ref || 'HEAD', '...'),
);
@ -272,7 +269,6 @@ export class CompareBranchNode extends ViewNode
private async getBehindFilesQuery(): Promise<FilesQueryResults> {
const files = await Container.git.getDiffStatus(
this.uri.repoPath!,
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
GitRevision.createRange(this.branch.ref, this._compareWith?.ref || 'HEAD', '...'),
);

+ 0
- 1
webpack.config.js View File

@ -2,7 +2,6 @@
/** @typedef {import('webpack').Configuration} WebpackConfig **/
/* eslint-disable @typescript-eslint/no-var-requires */
/* eslint-disable @typescript-eslint/prefer-nullish-coalescing */
/* eslint-disable @typescript-eslint/strict-boolean-expressions */
/* eslint-disable @typescript-eslint/prefer-optional-chain */
'use strict';

Loading…
Cancel
Save