Browse Source

Fixes #1968, #1027 - Fetch-> fatal: could not read Username

Uses the core git fetch command instead of a command-line
git fetch so VsCode will prompt the user for their username
and password. Pull & push also use their corresponding core commands.
main
Skyler Dawson 2 years ago
committed by Keith Daulton
parent
commit
85ba8d7d2f
4 changed files with 8 additions and 1 deletions
  1. +1
    -0
      CHANGELOG.md
  2. +1
    -0
      README.md
  3. +1
    -0
      src/constants.ts
  4. +5
    -1
      src/git/models/repository.ts

+ 1
- 0
CHANGELOG.md View File

@ -94,6 +94,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
- Fixes an issue where pinning not being respected in Commit Details view
- Fixes graph issue where search results that are merge commits are not highlighted when the `gitlens.graph.dimMergeCommits` setting is enabled
- Fixes graph issue where rows with tags belonging to a hovered branch are not highlighted when the `gitlens.graph.highlightRowsOnRefHover` setting is enabled
- Fixes [#1968](https://github.com/gitkraken/vscode-gitlens/issues/1968) & [#1027](https://github.com/gitkraken/vscode-gitlens/issues/1027) - Fetch-> fatal: could not read Username - thanks to [PR #2481](https://github.com/gitkraken/vscode-gitlens/pull/2481) by Skyler Dawson ([@foxwoods369](https://github.com/foxwoods369))
## [13.2.0] - 2022-12-20

+ 1
- 0
README.md View File

@ -1142,6 +1142,7 @@ A big thanks to the people that have contributed to this project:
- Ash Clarke ([@ashclarke](https://github.com/ashclarke)) — [contributions](https://github.com/gitkraken/vscode-gitlens/commits?author=ashclarke)
- Travis Collins ([@TravisTX](https://github.com/TravisTX)) — [contributions](https://github.com/gitkraken/vscode-gitlens/commits?author=TravisTX)
- Matt Cooper ([@vtbassmatt](https://github.com/vtbassmatt)) — [contributions](https://github.com/gitkraken/vscode-gitlens/commits?author=vtbassmatt)
- Skyler Dawson ([@foxwoods369](https://github.com/foxwoods369)) — [contributions](https://github.com/gitkraken/vscode-gitlens/commits?author=foxwoods369)
- Andrii Dieiev ([@IllusionMH](https://github.com/IllusionMH)) — [contributions](https://github.com/gitkraken/vscode-gitlens/commits?author=IllusionMH)
- egfx-notifications ([@egfx-notifications](https://github.com/egfx-notifications)) — [contributions](https://github.com/gitkraken/vscode-gitlens/commits?author=egfx-notifications)
- Segev Finer ([@segevfiner](https://github.com/segevfiner)) — [contributions](https://github.com/gitkraken/vscode-gitlens/commits?author=segevfiner)

+ 1
- 0
src/constants.ts View File

@ -352,6 +352,7 @@ export const enum CoreGitCommands {
Push = 'git.push',
PushForce = 'git.pushForce',
UndoCommit = 'git.undoCommit',
Fetch = 'git.fetch',
}
export const enum CoreGitConfiguration {

+ 5
- 1
src/git/models/repository.ts View File

@ -573,7 +573,11 @@ export class Repository implements Disposable {
remote?: string;
}) {
try {
await this.container.git.fetch(this.path, options);
if (options?.branch != null) {
await this.container.git.fetch(this.path, options);
} else {
void (await executeCoreGitCommand(CoreGitCommands.Fetch, this.path));
}
this.fireChange(RepositoryChange.Unknown);
} catch (ex) {

Loading…
Cancel
Save