From 7835bd8849becf219e9f4ed5b220c61a9a064fe7 Mon Sep 17 00:00:00 2001 From: Eric Amodio Date: Tue, 10 Sep 2019 00:59:01 -0400 Subject: [PATCH] Fixes #847 - not setting reset flag properly --- CHANGELOG.md | 1 + src/views/viewCommands.ts | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 37547ee..3bc96ab 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -60,6 +60,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p ### Fixed +- Fixes [#847](https://github.com/eamodio/vscode-gitlens/issues/847) - Refresh button on Compare With Branch view is not working - Fixes [#842](https://github.com/eamodio/vscode-gitlens/issues/842) - List of changed files in comparison to working tree only shows changed files in comparison to HEAD - Fixes [#828](https://github.com/eamodio/vscode-gitlens/issues/828) - Version comparison to show welcome message is not future proof — thanks to [PR #829](https://github.com/eamodio/vscode-gitlens/pull/829) by Arunprasad Rajkumar ([@arajkumar](https://github.com/arajkumar)) - Fixes [#821](https://github.com/eamodio/vscode-gitlens/issues/821) - Wrong comparison order in the Compare view when using Compare [HEAD|Working Tree] With comands diff --git a/src/views/viewCommands.ts b/src/views/viewCommands.ts index d6444d6..9304b79 100644 --- a/src/views/viewCommands.ts +++ b/src/views/viewCommands.ts @@ -68,12 +68,12 @@ export class ViewCommands { commands.registerCommand( 'gitlens.views.refreshNode', (node: ViewNode, reset?: boolean) => { - if (reset === undefined && nodeSupportsPaging(node)) { + if (reset == null && nodeSupportsPaging(node)) { node.maxCount = undefined; node.view.resetNodeLastMaxCount(node); } - return node.view.refreshNode(node, reset === undefined ? true : reset); + return node.view.refreshNode(node, reset == null ? true : reset); }, this );