From 71bf23ec9d8708e8e668cdb590db4e98c55a9da5 Mon Sep 17 00:00:00 2001 From: Eric Amodio Date: Mon, 23 Mar 2020 03:02:02 -0400 Subject: [PATCH] Removes needless check --- src/views/compareView.ts | 1 - src/views/fileHistoryView.ts | 1 - src/views/lineHistoryView.ts | 1 - src/views/repositoriesView.ts | 1 - src/views/searchView.ts | 1 - src/views/viewBase.ts | 2 +- 6 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/views/compareView.ts b/src/views/compareView.ts index 5b56677..984c5fc 100644 --- a/src/views/compareView.ts +++ b/src/views/compareView.ts @@ -70,7 +70,6 @@ export class CompareView extends ViewBase { protected onConfigurationChanged(e: ConfigurationChangeEvent) { if ( - !configuration.changed(e, 'views', 'compare') && !configuration.changed(e, 'views') && !configuration.changed(e, 'defaultDateFormat') && !configuration.changed(e, 'defaultDateSource') && diff --git a/src/views/fileHistoryView.ts b/src/views/fileHistoryView.ts index 73534b9..988a4cd 100644 --- a/src/views/fileHistoryView.ts +++ b/src/views/fileHistoryView.ts @@ -54,7 +54,6 @@ export class FileHistoryView extends ViewBase { protected onConfigurationChanged(e: ConfigurationChangeEvent) { if ( - !configuration.changed(e, 'views', 'fileHistory') && !configuration.changed(e, 'views') && !configuration.changed(e, 'defaultDateFormat') && !configuration.changed(e, 'defaultDateSource') && diff --git a/src/views/lineHistoryView.ts b/src/views/lineHistoryView.ts index 254b942..13f3a4b 100644 --- a/src/views/lineHistoryView.ts +++ b/src/views/lineHistoryView.ts @@ -53,7 +53,6 @@ export class LineHistoryView extends ViewBase { protected onConfigurationChanged(e: ConfigurationChangeEvent) { if ( - !configuration.changed(e, 'views', 'lineHistory') && !configuration.changed(e, 'views') && !configuration.changed(e, 'defaultDateFormat') && !configuration.changed(e, 'defaultDateSource') && diff --git a/src/views/repositoriesView.ts b/src/views/repositoriesView.ts index f72b3c0..f8f9bc4 100644 --- a/src/views/repositoriesView.ts +++ b/src/views/repositoriesView.ts @@ -114,7 +114,6 @@ export class RepositoriesView extends ViewBase { protected onConfigurationChanged(e: ConfigurationChangeEvent) { if ( - !configuration.changed(e, 'views', 'repositories') && !configuration.changed(e, 'views') && !configuration.changed(e, 'defaultDateFormat') && !configuration.changed(e, 'defaultDateSource') && diff --git a/src/views/searchView.ts b/src/views/searchView.ts index e63ea40..d9f1564 100644 --- a/src/views/searchView.ts +++ b/src/views/searchView.ts @@ -65,7 +65,6 @@ export class SearchView extends ViewBase { protected onConfigurationChanged(e: ConfigurationChangeEvent) { if ( - !configuration.changed(e, 'views', 'search') && !configuration.changed(e, 'views') && !configuration.changed(e, 'defaultDateFormat') && !configuration.changed(e, 'defaultDateSource') && diff --git a/src/views/viewBase.ts b/src/views/viewBase.ts index 0ef84f9..843ba74 100644 --- a/src/views/viewBase.ts +++ b/src/views/viewBase.ts @@ -96,7 +96,7 @@ export abstract class ViewBase> implements TreeData protected abstract onConfigurationChanged(e: ConfigurationChangeEvent): void; protected initialize(container?: string, options: { showCollapseAll?: boolean } = {}) { - if (this._disposable) { + if (this._disposable != null) { this._disposable.dispose(); this._onDidChangeTreeData = new EventEmitter(); }