Browse Source

Adds vscode issue TODO

main
Eric Amodio 7 years ago
parent
commit
6c33686335
3 changed files with 3 additions and 0 deletions
  1. +1
    -0
      src/annotations/annotationController.ts
  2. +1
    -0
      src/git/gitContextTracker.ts
  3. +1
    -0
      src/gitService.ts

+ 1
- 0
src/annotations/annotationController.ts View File

@ -233,6 +233,7 @@ export class AnnotationController extends Disposable {
for (const [key, p] of this._annotationProviders) { for (const [key, p] of this._annotationProviders) {
if (!TextDocumentComparer.equals(p.document, e.document)) continue; if (!TextDocumentComparer.equals(p.document, e.document)) continue;
// TODO: Rework this once https://github.com/Microsoft/vscode/issues/27231 is released in v1.13
// We have to defer because isDirty is not reliable inside this event // We have to defer because isDirty is not reliable inside this event
setTimeout(() => { setTimeout(() => {
// If the document is dirty all is fine, just kick out since the GitContextTracker will handle it // If the document is dirty all is fine, just kick out since the GitContextTracker will handle it

+ 1
- 0
src/git/gitContextTracker.ts View File

@ -75,6 +75,7 @@ export class GitContextTracker extends Disposable {
// this._unsubscribeToDocumentChanges(); // this._unsubscribeToDocumentChanges();
// this.updateBlameability(false); // this.updateBlameability(false);
// TODO: Rework this once https://github.com/Microsoft/vscode/issues/27231 is released in v1.13
// We have to defer because isDirty is not reliable inside this event // We have to defer because isDirty is not reliable inside this event
setTimeout(() => this._updateBlameability(!e.document.isDirty), 1); setTimeout(() => this._updateBlameability(!e.document.isDirty), 1);
} }

+ 1
- 0
src/gitService.ts View File

@ -214,6 +214,7 @@ export class GitService extends Disposable {
if (!this.UseCaching) return; if (!this.UseCaching) return;
if (e.document.uri.scheme !== DocumentSchemes.File) return; if (e.document.uri.scheme !== DocumentSchemes.File) return;
// TODO: Rework this once https://github.com/Microsoft/vscode/issues/27231 is released in v1.13
// We have to defer because isDirty is not reliable inside this event // We have to defer because isDirty is not reliable inside this event
setTimeout(() => { setTimeout(() => {
// If the document is dirty all is fine, we'll just wait for the save before clearing our cache // If the document is dirty all is fine, we'll just wait for the save before clearing our cache

Loading…
Cancel
Save