Browse Source

Fixes #1991 adds status bar accessibility labels

main
Eric Amodio 2 years ago
parent
commit
55df0eb5e2
2 changed files with 11 additions and 1 deletions
  1. +1
    -0
      CHANGELOG.md
  2. +10
    -1
      src/statusbar/statusBarController.ts

+ 1
- 0
CHANGELOG.md View File

@ -36,6 +36,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
### Fixed
- Fixes [#1991](https://github.com/gitkraken/vscode-gitlens/issues/1991) - Git lens status bar entry has an incomprehensible accessibility label
- Fixes [#2125](https://github.com/gitkraken/vscode-gitlens/issues/2125) - "git log" command in version 12.x is very slow
- Fixes [#2121](https://github.com/gitkraken/vscode-gitlens/issues/2121) - Typo in GitLens header — thanks to [PR #2122](https://github.com/gitkraken/vscode-gitlens/pull/2122) by Chase Knowlden ([@ChaseKnowlden](https://github.com/ChaseKnowlden))
- Fixes [#2082](https://github.com/gitkraken/vscode-gitlens/issues/2082) - GitLens Home view unreadable in certain themes

+ 10
- 1
src/statusbar/statusBarController.ts View File

@ -85,9 +85,12 @@ export class StatusBarController implements Disposable {
this._statusBarMode.command = Commands.SwitchMode;
this._statusBarMode.text = mode.statusBarItemName;
this._statusBarMode.tooltip = new MarkdownString(
`**${mode.statusBarItemName}** ${GlyphChars.Dash} ${mode.description}\n\n---\n\nClick to Switch GitLens Mode`,
`**${mode.statusBarItemName}** ${GlyphChars.Dash} ${mode.description}\n\n---\n\nClick to Switch GitLens Modes`,
true,
);
this._statusBarMode.accessibilityInformation = {
label: `GitLens Mode: ${mode.statusBarItemName}\nClick to Switch GitLens Modes`,
};
this._statusBarMode.show();
} else {
this._statusBarMode?.dispose();
@ -311,6 +314,9 @@ export class StatusBarController implements Disposable {
}
this._statusBarBlame.tooltip = tooltip;
this._statusBarBlame.accessibilityInformation = {
label: `${this._statusBarBlame.text}\n${tooltip}`,
};
if (this._tooltipDelayTimer != null) {
clearTimeout(this._tooltipDelayTimer);
@ -388,6 +394,9 @@ export class StatusBarController implements Disposable {
tooltip.appendMarkdown(`\n\n---\n\n${actionTooltip}`);
statusBarItem.tooltip = tooltip;
statusBarItem.accessibilityInformation = {
label: `${statusBarItem.text}\n${actionTooltip}`,
};
}
private async waitForPendingPullRequest(

Loading…
Cancel
Save