Просмотр исходного кода

Fixes settings token popup clicking

main
Eric Amodio 2 лет назад
Родитель
Сommit
48a8e194d8
2 измененных файлов: 2 добавлений и 10 удалений
  1. +1
    -0
      CHANGELOG.md
  2. +1
    -10
      src/webviews/apps/shared/appWithConfigBase.ts

+ 1
- 0
CHANGELOG.md Просмотреть файл

@ -30,6 +30,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
- Fixes [#1882](https://github.com/gitkraken/vscode-gitlens/issues/1882) - Blame annotations not showing anymore after update
- Fixes [#1787](https://github.com/gitkraken/vscode-gitlens/issues/1787) - Remove '-review' from Gerrit Remote reviewDomain() — thanks to [PR #1954](https://github.com/gitkraken/vscode-gitlens/pull/1954) by Felipe Santos ([@felipecrs](https://github.com/felipecrs))
- Fixes [#1902](https://github.com/gitkraken/vscode-gitlens/issues/1902) - Support replacing mirror/replica domain with main domain for remote provider — thanks to [PR #1954](https://github.com/gitkraken/vscode-gitlens/pull/1954) by Felipe Santos ([@felipecrs](https://github.com/felipecrs))
- Fixes an issue where clicking on tokens on the Settings editor popup wouldn't add the token into the input
## [12.0.6] - 2022-04-12

+ 1
- 10
src/webviews/apps/shared/appWithConfigBase.ts Просмотреть файл

@ -58,7 +58,7 @@ export abstract class AppWithConfig extends Ap
(e, target: HTMLInputElement) => this.onInputChanged(target),
),
DOM.on('select[data-setting]', 'change', (e, target: HTMLSelectElement) => this.onInputSelected(target)),
DOM.on('.popup', 'mousedown', (e, target: HTMLElement) => this.onPopupMouseDown(target, e)),
DOM.on('.token[data-token]', 'mousedown', (e, target: HTMLElement) => this.onTokenMouseDown(target, e)),
);
return disposables;
@ -222,15 +222,6 @@ export abstract class AppWithConfig extends Ap
this.applyChanges();
}
protected onPopupMouseDown(element: HTMLElement, e: MouseEvent) {
e.preventDefault();
const el = e.target as HTMLElement;
if (el?.matches('[data-token]')) {
this.onTokenMouseDown(el, e);
}
}
protected onTokenMouseDown(element: HTMLElement, e: MouseEvent) {
if (this._updating) return;

Загрузка…
Отмена
Сохранить