Browse Source

Fixes #1246 - bad encoding caused missing fallback

main
Eric Amodio 4 years ago
parent
commit
37b4114ee5
2 changed files with 5 additions and 3 deletions
  1. +1
    -0
      CHANGELOG.md
  2. +4
    -3
      src/annotations/gutterBlameAnnotationProvider.ts

+ 1
- 0
CHANGELOG.md View File

@ -25,6 +25,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
### Fixed
- Fixes [#1246](https://github.com/eamodio/vscode-gitlens/issues/1246) - Gutter Blame avatar does not use Gravatar fallback style
- Fixes [#1208](https://github.com/eamodio/vscode-gitlens/issues/1208) - Connect to Github notification is noisy
- Fixes [#526](https://github.com/eamodio/vscode-gitlens/issues/526) - FAILED in gitlens.outputLevel=verbose; likely due to regex not in quotes
- Fixes [#1222](https://github.com/eamodio/vscode-gitlens/issues/1222) - GitLens: Open Associated Pull Request doesn't work

+ 4
- 3
src/annotations/gutterBlameAnnotationProvider.ts View File

@ -210,13 +210,14 @@ export class GutterBlameAnnotationProvider extends BlameAnnotationProviderBase {
) {
let avatarDecoration = map.get(commit.email!);
if (avatarDecoration == null) {
const url = (await commit.getAvatarUri({ defaultStyle: gravatarDefault, size: 16 })).toString(true);
avatarDecoration = {
contentText: '',
height: '16px',
width: '16px',
textDecoration: `none;position:absolute;top:1px;left:5px;background:url(${(
await commit.getAvatarUri({ defaultStyle: gravatarDefault })
).toString()});background-size:16px 16px;margin-left: 0 !important`,
textDecoration: `none;position:absolute;top:1px;left:5px;background:url(${encodeURI(
url,
)});background-size:16px 16px;margin-left: 0 !important`,
};
map.set(commit.email!, avatarDecoration);
}

Loading…
Cancel
Save