Browse Source

Reverts diff editor changes for diff w/ working

Since we are going forward in time, the changes didn't make sense
main
Eric Amodio 5 years ago
parent
commit
25d38956c6
2 changed files with 4 additions and 23 deletions
  1. +0
    -2
      src/commands/diffWithNext.ts
  2. +4
    -21
      src/commands/diffWithWorking.ts

+ 0
- 2
src/commands/diffWithNext.ts View File

@ -12,7 +12,6 @@ export interface DiffWithNextCommandArgs {
commit?: GitLogCommit; commit?: GitLogCommit;
range?: Range; range?: Range;
inDiffEditor?: boolean;
line?: number; line?: number;
showOptions?: TextDocumentShowOptions; showOptions?: TextDocumentShowOptions;
} }
@ -36,7 +35,6 @@ export class DiffWithNextCommand extends ActiveEditorCommand {
return this.execute(context.editor, context.editor.document.uri, args); return this.execute(context.editor, context.editor.document.uri, args);
} }
} }
args.inDiffEditor = true;
} }
return this.execute(context.editor, context.uri, args); return this.execute(context.editor, context.uri, args);

+ 4
- 21
src/commands/diffWithWorking.ts View File

@ -11,7 +11,6 @@ import { UriComparer } from '../comparers';
export interface DiffWithWorkingCommandArgs { export interface DiffWithWorkingCommandArgs {
commit?: GitCommit; commit?: GitCommit;
inDiffEditor?: boolean;
line?: number; line?: number;
showOptions?: TextDocumentShowOptions; showOptions?: TextDocumentShowOptions;
} }
@ -24,8 +23,8 @@ export class DiffWithWorkingCommand extends ActiveEditorCommand {
protected preExecute(context: CommandContext, args: DiffWithWorkingCommandArgs = {}) { protected preExecute(context: CommandContext, args: DiffWithWorkingCommandArgs = {}) {
if ( if (
context.command === Commands.DiffWithWorkingInDiff ||
(context.editor !== undefined && context.editor.viewColumn === undefined)
context.command === Commands.DiffWithWorkingInDiff
// || (context.editor !== undefined && context.editor.viewColumn === undefined)
) { ) {
// HACK: If in a diff, try to determine if we are on the right or left side // HACK: If in a diff, try to determine if we are on the right or left side
// If there is a context uri and it doesn't match the editor uri, assume we are on the left // If there is a context uri and it doesn't match the editor uri, assume we are on the left
@ -35,8 +34,6 @@ export class DiffWithWorkingCommand extends ActiveEditorCommand {
return this.execute(context.editor, context.editor.document.uri, args); return this.execute(context.editor, context.editor.document.uri, args);
} }
} }
args.inDiffEditor = true;
} }
return this.execute(context.editor, context.uri, args); return this.execute(context.editor, context.uri, args);
@ -66,18 +63,10 @@ export class DiffWithWorkingCommand extends ActiveEditorCommand {
const status = await Container.git.getStatusForFile(gitUri.repoPath!, gitUri.fsPath); const status = await Container.git.getStatusForFile(gitUri.repoPath!, gitUri.fsPath);
if (status !== undefined && status.indexStatus !== undefined) { if (status !== undefined && status.indexStatus !== undefined) {
let sha = GitService.uncommittedStagedSha;
if (args.inDiffEditor) {
const commit = await Container.git.getCommitForFile(gitUri.repoPath!, gitUri.fsPath);
if (commit === undefined) return Messages.showCommitHasNoPreviousCommitWarningMessage();
sha = commit.sha;
}
const diffArgs: DiffWithCommandArgs = { const diffArgs: DiffWithCommandArgs = {
repoPath: gitUri.repoPath, repoPath: gitUri.repoPath,
lhs: { lhs: {
sha: sha,
sha: GitService.uncommittedStagedSha,
uri: gitUri.documentUri() uri: gitUri.documentUri()
}, },
rhs: { rhs: {
@ -92,15 +81,9 @@ export class DiffWithWorkingCommand extends ActiveEditorCommand {
} }
} }
// If we are in a diff editor, assume we are on the right side, and need to move back 2 revisions
let sha = gitUri.sha;
if (args.inDiffEditor && sha !== undefined) {
sha = `${sha}^`;
}
try { try {
args.commit = await Container.git.getCommitForFile(gitUri.repoPath, gitUri.fsPath, { args.commit = await Container.git.getCommitForFile(gitUri.repoPath, gitUri.fsPath, {
ref: sha,
ref: gitUri.sha,
firstIfNotFound: true firstIfNotFound: true
}); });
if (args.commit === undefined) { if (args.commit === undefined) {

Loading…
Cancel
Save