Browse Source

Forces reset on clear

Avoids saving/re-saving object if it isn't changing
main
Eric Amodio 2 years ago
parent
commit
1fc4d399ef
1 changed files with 4 additions and 2 deletions
  1. +4
    -2
      src/views/nodes/compareBranchNode.ts

+ 4
- 2
src/views/nodes/compareBranchNode.ts View File

@ -181,8 +181,6 @@ export class CompareBranchNode extends ViewNode
@log() @log()
async clear() { async clear() {
if (this._compareWith == null) return;
this._compareWith = undefined; this._compareWith = undefined;
await this.updateCompareWith(undefined); await this.updateCompareWith(undefined);
@ -354,6 +352,8 @@ export class CompareBranchNode extends ViewNode
WorkspaceState.BranchComparisons, WorkspaceState.BranchComparisons,
); );
if (comparisons == null) { if (comparisons == null) {
if (compareWith == null) return;
comparisons = Object.create(null) as BranchComparisons; comparisons = Object.create(null) as BranchComparisons;
} }
@ -362,6 +362,8 @@ export class CompareBranchNode extends ViewNode
if (compareWith != null) { if (compareWith != null) {
comparisons[id] = { ...compareWith }; comparisons[id] = { ...compareWith };
} else { } else {
if (comparisons[id] == null) return;
const { [id]: _, ...rest } = comparisons; const { [id]: _, ...rest } = comparisons;
comparisons = rest; comparisons = rest;
} }

Loading…
Cancel
Save