wlxsp
/
test1
1
0
Fork 0
Code Issues 0 Pull Requests 0 Releases 0 Wiki Activity
Browse Source

Renames showWelcomeOrWhatsNew 

And limits it to only affect the welcome experience since showWhatsNewAfterUpgrades already exists
main
Eric Amodio 4 years ago
parent
b30f4bcf0d
commit
1f8c16fa58
5 changed files with 8 additions and 8 deletions
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. +2
    -1
      CHANGELOG.md
  2. +2
    -1
      README.md
  3. +2
    -2
      package.json
  4. +1
    -1
      src/config.ts
  5. +1
    -3
      src/extension.ts

+ 2
- 1
CHANGELOG.md View File

@ -9,7 +9,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
### Added ### Added
- Adds ability to show gutter heatmap in the gutter and/or on the scroll bar — closes [#297](https://github.com/eamodio/vscode-gitlens/issues/297) - Adds ability to show gutter heatmap in the gutter and/or on the scroll bar — closes [#297](https://github.com/eamodio/vscode-gitlens/issues/297)
- Adds `gitlens.heatmap.locations` setting to specify where the indicators of the gutter heatmap annotations will be shown
- Adds a `gitlens.heatmap.locations` setting to specify where the indicators of the gutter heatmap annotations will be shown
- Adds a `gitlens.fileAnnotations.command` setting to specify whether the file annotations button in the editor title shows a menu or immediately toggles the specified file annotations — closes [#1165](https://github.com/eamodio/vscode-gitlens/issues/1165) thanks to [PR #1171](https://github.com/eamodio/vscode-gitlens/pull/1171) by Raaj Patil ([@arrpee](https://github.com/arrpee)) - Adds a `gitlens.fileAnnotations.command` setting to specify whether the file annotations button in the editor title shows a menu or immediately toggles the specified file annotations — closes [#1165](https://github.com/eamodio/vscode-gitlens/issues/1165) thanks to [PR #1171](https://github.com/eamodio/vscode-gitlens/pull/1171) by Raaj Patil ([@arrpee](https://github.com/arrpee))
- Adds this new option to the _Menus & Toolbars_ section of the GitLens Interactive Settings - Adds this new option to the _Menus & Toolbars_ section of the GitLens Interactive Settings
- Adds an _Open File on Remote From..._ command (`gitlens.openFileOnRemoteFrom`) to open a file or revision on a specific branch or tag on the remote provider — closes [#1071](https://github.com/eamodio/vscode-gitlens/issues/1071) - Adds an _Open File on Remote From..._ command (`gitlens.openFileOnRemoteFrom`) to open a file or revision on a specific branch or tag on the remote provider — closes [#1071](https://github.com/eamodio/vscode-gitlens/issues/1071)
@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
- Adds preview extensibility APIs - Adds preview extensibility APIs
- Adds a preview _action runner_ extensibility point to provide a runner (handler) for a new _createPullRequest_ and _openPullRequest_ actions — see `gitlens.d.ts` for API definitions - Adds a preview _action runner_ extensibility point to provide a runner (handler) for a new _createPullRequest_ and _openPullRequest_ actions — see `gitlens.d.ts` for API definitions
- Preview APIs are only available in the Insiders edition - Preview APIs are only available in the Insiders edition
- Adds a `gitlens.showWelcomeOnInstall` setting to specify whether to show the Welcome (Quick Setup) experience on first install — closes [#1049](https://github.com/eamodio/vscode-gitlens/issues/1049) thanks to [PR #1258](https://github.com/eamodio/vscode-gitlens/pull/1258) by Rickard ([@rickardp](https://github.com/rickardp))
### Changed ### Changed

+ 2
- 1
README.md View File

@ -903,7 +903,7 @@ See also [View Settings](#view-settings- 'Jump to the View settings')
| `gitlens.insiders` | Specifies whether to enable experimental features | | `gitlens.insiders` | Specifies whether to enable experimental features |
| `gitlens.liveshare.allowGuestAccess` | Specifies whether to allow guest access to GitLens features when using Visual Studio Live Share | | `gitlens.liveshare.allowGuestAccess` | Specifies whether to allow guest access to GitLens features when using Visual Studio Live Share |
| `gitlens.outputLevel` | Specifies how much (if any) output will be sent to the GitLens output channel | | `gitlens.outputLevel` | Specifies how much (if any) output will be sent to the GitLens output channel |
| `gitlens.showWelcomeOrWhatsNew` | Specifies whether to show the Welcome (Quick Setup) experience on first install, or the What's New notification after upgrading to new feature releases |
| `gitlens.showWelcomeOnInstall` | Specifies whether to show the Welcome (Quick Setup) experience on first install |
| `gitlens.showWhatsNewAfterUpgrades` | Specifies whether to show the What's New notification after upgrading to new feature releases | | `gitlens.showWhatsNewAfterUpgrades` | Specifies whether to show the What's New notification after upgrading to new feature releases |
| `gitlens.advanced.abbreviatedShaLength` | Specifies the length of abbreviated commit SHAs (shas) | | `gitlens.advanced.abbreviatedShaLength` | Specifies the length of abbreviated commit SHAs (shas) |
| `gitlens.advanced.blame.customArguments` | Specifies additional arguments to pass to the `git blame` command | | `gitlens.advanced.blame.customArguments` | Specifies additional arguments to pass to the `git blame` command |
@ -985,6 +985,7 @@ A big thanks to the people that have contributed to this project:
- Connor Peet ([@connor4312](https://github.com/connor4312)) — [contributions](https://github.com/eamodio/vscode-gitlens/commits?author=connor4312) - Connor Peet ([@connor4312](https://github.com/connor4312)) — [contributions](https://github.com/eamodio/vscode-gitlens/commits?author=connor4312)
- Maxim Pekurin ([@pmaxim25](https://github.com/pmaxim25)) — [contributions](https://github.com/eamodio/vscode-gitlens/commits?author=pmaxim25) - Maxim Pekurin ([@pmaxim25](https://github.com/pmaxim25)) — [contributions](https://github.com/eamodio/vscode-gitlens/commits?author=pmaxim25)
- Arunprasad Rajkumar ([@arajkumar](https://github.com/arajkumar)) — [contributions](https://github.com/eamodio/vscode-gitlens/commits?author=arajkumar) - Arunprasad Rajkumar ([@arajkumar](https://github.com/arajkumar)) — [contributions](https://github.com/eamodio/vscode-gitlens/commits?author=arajkumar)
- Rickard ([@rickardp](https://github.com/rickardp)) — [contributions](https://github.com/eamodio/vscode-gitlens/commits?author=rickardp)
- Johannes Rieken ([@jrieken](https://github.com/jrieken)) — [contributions](https://github.com/eamodio/vscode-gitlens/commits?author=jrieken) - Johannes Rieken ([@jrieken](https://github.com/jrieken)) — [contributions](https://github.com/eamodio/vscode-gitlens/commits?author=jrieken)
- Guillaume Rozan ([@rozangu1](https://github.com/rozangu1)) — [contributions](https://github.com/eamodio/vscode-gitlens/commits?author=rozangu1) - Guillaume Rozan ([@rozangu1](https://github.com/rozangu1)) — [contributions](https://github.com/eamodio/vscode-gitlens/commits?author=rozangu1)
- ryenus ([@ryenus](https://github.com/ryenus)) — [contributions](https://github.com/eamodio/vscode-gitlens/commits?author=ryenus) - ryenus ([@ryenus](https://github.com/ryenus)) — [contributions](https://github.com/eamodio/vscode-gitlens/commits?author=ryenus)

+ 2
- 2
package.json View File

@ -1463,10 +1463,10 @@
"markdownDescription": "Specifies user-defined remote (code-hosting) services or custom domains for built-in remote services", "markdownDescription": "Specifies user-defined remote (code-hosting) services or custom domains for built-in remote services",
"scope": "resource" "scope": "resource"
}, },
"gitlens.showWelcomeOrWhatsNew": {
"gitlens.showWelcomeOnInstall": {
"type": "boolean", "type": "boolean",
"default": true, "default": true,
"markdownDescription": "Specifies whether to show the Welcome (Quick Setup) experience on first install, or the What's New notification after upgrading to new feature releases",
"markdownDescription": "Specifies whether to show the Welcome (Quick Setup) experience on first install",
"scope": "window" "scope": "window"
}, },
"gitlens.showWhatsNewAfterUpgrades": { "gitlens.showWhatsNewAfterUpgrades": {

+ 1
- 1
src/config.ts View File

@ -108,7 +108,7 @@ export interface Config {
modes: Record<string, ModeConfig>; modes: Record<string, ModeConfig>;
outputLevel: TraceLevel; outputLevel: TraceLevel;
remotes: RemotesConfig[] | null; remotes: RemotesConfig[] | null;
showWelcomeOrWhatsNew: boolean;
showWelcomeOnInstall: boolean;
showWhatsNewAfterUpgrades: boolean; showWhatsNewAfterUpgrades: boolean;
sortBranchesBy: BranchSorting; sortBranchesBy: BranchSorting;
sortTagsBy: TagSorting; sortTagsBy: TagSorting;

+ 1
- 3
src/extension.ts View File

@ -198,7 +198,7 @@ export function notifyOnUnsupportedGitVersion(version: string) {
async function showWelcomeOrWhatsNew(version: string, previousVersion: string | undefined) { async function showWelcomeOrWhatsNew(version: string, previousVersion: string | undefined) {
if (previousVersion == null) { if (previousVersion == null) {
Logger.log('GitLens first-time install'); Logger.log('GitLens first-time install');
if (!Container.config.showWelcomeOrWhatsNew) return;
if (Container.config.showWelcomeOnInstall === false) return;
await commands.executeCommand(Commands.ShowWelcomePage); await commands.executeCommand(Commands.ShowWelcomePage);
@ -209,8 +209,6 @@ async function showWelcomeOrWhatsNew(version: string, previousVersion: string |
Logger.log(`GitLens upgraded from v${previousVersion} to v${version}`); Logger.log(`GitLens upgraded from v${previousVersion} to v${version}`);
} }
if (!Container.config.showWelcomeOrWhatsNew) return;
const [major, minor] = version.split('.').map(v => parseInt(v, 10)); const [major, minor] = version.split('.').map(v => parseInt(v, 10));
const [prevMajor, prevMinor] = previousVersion.split('.').map(v => parseInt(v, 10)); const [prevMajor, prevMinor] = previousVersion.split('.').map(v => parseInt(v, 10));
if ( if (

Write Preview
Loading…
Cancel
Save