Renames parameters

src/commands/openComparisonOnRemote.ts

@@ -46,8 +46,8 @@ export class OpenComparisonOnRemoteCommand extends Command {
 			void (await executeCommand<OpenOnRemoteCommandArgs>(Commands.OpenOnRemote, {
 				resource: {
 					type: RemoteResourceType.Comparison,
-					ref1: args.ref1,
-					ref2: args.ref2,
+					base: args.ref1,
+					compare: args.ref2,
 					notation: args.notation,
 				},
 				repoPath: args.repoPath,

src/commands/openOnRemote.ts

@@ -107,7 +107,7 @@ export class OpenOnRemoteCommand extends Command {
 						GlyphChars.Dot,
 						2,
 						2,
-					)}${GitRevision.createRange(args.resource.ref1, args.resource.ref2, '...')}`;
+					)}${GitRevision.createRange(args.resource.base, args.resource.compare, '...')}`;
 					break;
 
 				case RemoteResourceType.File:

src/git/remotes/azure-devops.ts

@@ -124,8 +124,8 @@ export class AzureDevOpsRemote extends RemoteProvider {
 		return `${this.baseUrl}/commit/${sha}`;
 	}
 
-	protected getUrlForComparison(ref1: string, ref2: string, _notation: '..' | '...'): string {
-		return `${this.baseUrl}/branchCompare?baseVersion=GB${ref1}&targetVersion=GB${ref2}`;
+	protected getUrlForComparison(base: string, compare: string, _notation: '..' | '...'): string {
+		return `${this.baseUrl}/branchCompare?baseVersion=GB${base}&targetVersion=GB${compare}`;
 	}
 
 	protected getUrlForFile(fileName: string, branch?: string, sha?: string, range?: Range): string {

src/git/remotes/bitbucket-server.ts

@@ -126,8 +126,8 @@ export class BitbucketServerRemote extends RemoteProvider {
 		return `${this.baseUrl}/commits/${sha}`;
 	}
 
-	protected getUrlForComparison(ref1: string, ref2: string, _notation: '..' | '...'): string {
-		return `${this.baseUrl}/branches/compare/${ref1}%0D${ref2}`;
+	protected getUrlForComparison(base: string, compare: string, _notation: '..' | '...'): string {
+		return `${this.baseUrl}/branches/compare/${base}%0D${compare}`;
 	}
 
 	protected getUrlForFile(fileName: string, branch?: string, sha?: string, range?: Range): string {

src/git/remotes/bitbucket.ts

@@ -119,8 +119,8 @@ export class BitbucketRemote extends RemoteProvider {
 		return `${this.baseUrl}/commits/${sha}`;
 	}
 
-	protected getUrlForComparison(ref1: string, ref2: string, _notation: '..' | '...'): string {
-		return `${this.baseUrl}/branches/compare/${ref1}%0D${ref2}`;
+	protected getUrlForComparison(base: string, compare: string, _notation: '..' | '...'): string {
+		return `${this.baseUrl}/branches/compare/${base}%0D${compare}`;
 	}
 
 	protected getUrlForFile(fileName: string, branch?: string, sha?: string, range?: Range): string {

src/git/remotes/custom.ts

@@ -44,12 +44,12 @@ export class CustomRemote extends RemoteProvider {
 		return Strings.interpolate(this.urls.commit, this.getContext({ id: sha }));
 	}
 
-	protected getUrlForComparison(ref1: string, ref2: string, notation: '..' | '...'): string | undefined {
+	protected getUrlForComparison(base: string, compare: string, notation: '..' | '...'): string | undefined {
 		if (this.urls.comparison == null) return undefined;
 
 		return Strings.interpolate(
 			this.urls.comparison,
-			this.getContext({ ref1: ref1, ref2: ref2, notation: notation }),
+			this.getContext({ ref1: base, ref2: compare, notation: notation }),
 		);
 	}
 

src/git/remotes/github.ts

@@ -139,8 +139,8 @@ export class GitHubRemote extends RichRemoteProvider {
 		return `${this.baseUrl}/commit/${sha}`;
 	}
 
-	protected getUrlForComparison(ref1: string, ref2: string, notation: '..' | '...'): string {
-		return `${this.baseUrl}/compare/${ref1}${notation}${ref2}`;
+	protected getUrlForComparison(base: string, compare: string, notation: '..' | '...'): string {
+		return `${this.baseUrl}/compare/${base}${notation}${compare}`;
 	}
 
 	protected getUrlForFile(fileName: string, branch?: string, sha?: string, range?: Range): string {

src/git/remotes/gitlab.ts

@@ -114,8 +114,8 @@ export class GitLabRemote extends RemoteProvider {
 		return `${this.baseUrl}/commit/${sha}`;
 	}
 
-	protected getUrlForComparison(ref1: string, ref2: string, notation: '..' | '...'): string {
-		return `${this.baseUrl}/-/compare/${ref1}${notation}${ref2}`;
+	protected getUrlForComparison(base: string, compare: string, notation: '..' | '...'): string {
+		return `${this.baseUrl}/-/compare/${base}${notation}${compare}`;
 	}
 
 	protected getUrlForFile(fileName: string, branch?: string, sha?: string, range?: Range): string {

src/git/remotes/provider.ts

@@ -49,8 +49,8 @@ export type RemoteResource =
 	  }
 	| {
 			type: RemoteResourceType.Comparison;
-			ref1: string;
-			ref2: string;
+			base: string;
+			compare: string;
 			notation?: '..' | '...';
 	  }
 	| {
@@ -151,7 +151,7 @@ export abstract class RemoteProvider implements RemoteProviderReference {
 			case RemoteResourceType.Commit:
 				return encodeURI(this.getUrlForCommit(resource.sha));
 			case RemoteResourceType.Comparison: {
-				const url = this.getUrlForComparison?.(resource.ref1, resource.ref2, resource.notation ?? '...');
+				const url = this.getUrlForComparison?.(resource.base, resource.compare, resource.notation ?? '...');
 				return url != null ? encodeURI(url) : undefined;
 			}
 			case RemoteResourceType.File:
@@ -199,7 +199,7 @@ export abstract class RemoteProvider implements RemoteProviderReference {
 
 	protected abstract getUrlForCommit(sha: string): string;
 
-	protected getUrlForComparison?(ref1: string, ref2: string, notation: '..' | '...'): string | undefined;
+	protected getUrlForComparison?(base: string, compare: string, notation: '..' | '...'): string | undefined;
 
 	protected abstract getUrlForFile(fileName: string, branch?: string, sha?: string, range?: Range): string;
 

src/quickpicks/remoteProviderPicker.ts

@@ -41,12 +41,12 @@ export class CopyOrOpenRemoteCommandQuickPickItem extends CommandQuickPickItem {
 	async execute(): Promise<void> {
 		let resource = this.resource;
 		if (resource.type === RemoteResourceType.Comparison) {
-			if (GitBranch.getRemote(resource.ref1) === this.remote.name) {
-				resource = { ...resource, ref1: GitBranch.getNameWithoutRemote(resource.ref1) };
+			if (GitBranch.getRemote(resource.base) === this.remote.name) {
+				resource = { ...resource, base: GitBranch.getNameWithoutRemote(resource.base) };
 			}
 
-			if (GitBranch.getRemote(resource.ref2) === this.remote.name) {
-				resource = { ...resource, ref2: GitBranch.getNameWithoutRemote(resource.ref2) };
+			if (GitBranch.getRemote(resource.compare) === this.remote.name) {
+				resource = { ...resource, compare: GitBranch.getNameWithoutRemote(resource.compare) };
 			}
 		} else if (
 			resource.type === RemoteResourceType.File &&