I recently encountered a problem with this because Windows doesn't allow
files to be deleted when there's open handles to them.

Other files opened by leveldb are not affected because by and large they
are using CreateFileA, which does not allow inheritance when
lpSecurityAttributes is null (ref:
https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilea)

However, fopen() _does_ allow inheritance, and it needs to be expressly
disabled.
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/fopen-wfopen?view=msvc-160

PiperOrigin-RevId: 395824737

Fix typo of comment of FindLargestKey function

PiperOrigin-RevId: 394542401

PiperOrigin-RevId: 388341429

Xcode (drives macOS image) : 12.2 => 12.5
Clang                      : 10 => 12
GCC                        : 10 => 11
PiperOrigin-RevId: 375582717

Roll third-party dependencies.

key across multiple files.

As reported in Github issue #339, it is incorrect to split the
same user key across multiple compacted files since it causes
tombstones/newer-versions to be dropped, thereby exposing obsolete
data. There was a fix for #339, but it ended up not fully fixing
the problem. (It checked for boundary problems in the first level
being compacted, but not the second). This problem was revealed
by Github issue 887.

We now adjust boundaries to avoid splitting user keys in both the
first level and the second level.

PiperOrigin-RevId: 374921082

Use function instead of original expression.

PiperOrigin-RevId: 360972284

PiperOrigin-RevId: 359111035

Using %zu for size_t instead of %ld.

PiperOrigin-RevId: 357976882

Using the partial path offers more flexibility to projects which
may checkout google/benchmark to a different location.

PiperOrigin-RevId: 357819911

Fixes https://github.com/google/leveldb/issues/872

PiperOrigin-RevId: 353657701

PiperOrigin-RevId: 351442409

Add logging with debugging information when failing to load a version set.

PiperOrigin-RevId: 351432332

This is beneficial when iterators are reused and seeks are not random
but increasing. It is additionally beneficial with larger block sizes and keys with common prefixes.

Add a benchmark "seekordered" to db_bench that reuses iterators across
increasing seeks.  Add support to the benchmark to count comparisons made and to support common key prefix length. Change benchmark random seeds to be reproducible for entire benchmark suite executions but unique for threads in different benchmarks runs.  This changes a benchmark suite of readrandom,seekrandom from having a 100% found ratio as previously it had the same seed used for fillrandom.

./db_bench --benchmarks=fillrandom,compact,seekordered --block_size=262144 --comparisons=1 --key_prefix=100

without this change (though with benchmark changes):
seekrandom   :      55.309 micros/op; (631820 of 1000000 found)
Comparisons: 27001049
seekordered  :       1.732 micros/op; (631882 of 1000000 found)
Comparisons: 26998402

with this change:
seekrandom   :      55.866 micros/op; (631820 of 1000000 found)
Comparisons: 26952143
seekordered  :       1.686 micros/op; (631882 of 1000000 found)
Comparisons: 25549369

For ordered seeking, this is a reduction of 5% comparisons and a 3% speedup. For random seeking (with single use iterators) the comparisons and speed are less than 1% and likely noise.

PiperOrigin-RevId: 351149832

PiperOrigin-RevId: 349711809

PiperOrigin-RevId: 347391876

Fixup for adding the third_party/benchmark submodule.

PiperOrigin-RevId: 344909677

PiperOrigin-RevId: 344871226

PiperOrigin-RevId: 344817715

PiperOrigin-RevId: 339310928

PiperOrigin-RevId: 339287832

PiperOrigin-RevId: 329720018

PiperOrigin-RevId: 321372819

remove return value of GetApproximateSizes in index.md

PiperOrigin-RevId: 321000544

PiperOrigin-RevId: 309738404

PiperOrigin-RevId: 309138195

PiperOrigin-RevId: 309136120

PiperOrigin-RevId: 309110431

This CL makes the following substitutions.

* assert.h -> cassert
* math.h -> cmath
* stdarg.h -> cstdarg
* stddef.h -> cstddef
* stdint.h -> cstdint
* stdio.h -> cstdio
* stdlib.h -> cstdlib
* string.h -> cstring

PiperOrigin-RevId: 309080151

PiperOrigin-RevId: 308839805