Reilly Grant
13ebad24dc
Address comments.
1 rok temu
Reilly Grant
89ea7f2643
Fix tests when run against ChromiumEnv
There are a couple differences between ChromiumEnv and
PosixEnv/WindowsEnv which cause test failures that are fixed (or at
least patched over) in this change:
* NewSequentialFile() and NewRandomAccessFile() return Status::IOError
rather than Status::NotFound when a file is not found, due to
https://crbug.com/760362 . This means a few tests need to expect a
different error result.
* GetChildren() never returns the '.' or '..' entries.
* As allowed by the documentation for Env::Schedule(), ChromiumEnv may
execute functions on multiple threads and guarantees no sequencing.
EnvTest.RunMany assumed that functions ran in order. The test has been
updated.
1 rok temu
Sanjay Ghemawat
fb644cb445
Stop future writes if a log file Close() fails.
See https://github.com/google/leveldb/issues/1081
PiperOrigin-RevId: 499519182
1 rok temu
leveldb Team
aa5479bbf4
Fix maintenance text
PiperOrigin-RevId: 461725664
2 lat temu
Victor Costan
ca684d00b5
Fix Markdown formatting in README.
PiperOrigin-RevId: 461722304
2 lat temu
leveldb Team
7b650f85de
Add note on current development state
PiperOrigin-RevId: 461695246
2 lat temu
Victor Costan
0a9b7b8e95
Merge pull request #1036 from chjj:benchmark-compression
PiperOrigin-RevId: 461612590
2 lat temu
leveldb Team
fff74f20ff
Use GTEST_SKIP in leveldb:table_test
This replaces a usage of fprintf to stderr
PiperOrigin-RevId: 454620969
2 lat temu
Christopher Jeffrey
9e1c274074
Add compression flag to benchmarks.
2 lat temu
Victor Costan
d019e3605f
Merge pull request #1008 from pkasting:main
PiperOrigin-RevId: 447466466
2 lat temu
Peter Kasting
8b5b1ca96c
Fixes for C++20 support.
Structs with user-declared constructors are no longer considered
aggregates. Just remove the constructor declaration where applicable.
Bug: chromium:1284275
2 lat temu
Victor Costan
4fb146810c
The master branch was renamed to main.
PiperOrigin-RevId: 422409116
2 lat temu
Victor Costan
479a1f4e9b
Update contributing guidelines.
* Align CONTRIBUTING.md with the google/new-project template.
* Explain the support story for the CMake config.
PiperOrigin-RevId: 421120645
2 lat temu
Victor Costan
1b51a3a968
Merge pull request #506 from lingbin:fix_issue_505
PiperOrigin-RevId: 420787858
2 lat temu
Victor Costan
a797000713
Merge pull request #893 from myccccccc:master
PiperOrigin-RevId: 420783873
2 lat temu
Victor Costan
bf4fcd85b5
Merge pull request #888 from JayiceZ:fix_typo
PiperOrigin-RevId: 420783487
2 lat temu
Victor Costan
8a68093c84
Merge pull request #652 from caodhuan:master
PiperOrigin-RevId: 420782536
2 lat temu
Victor Costan
bfea90d883
Merge pull request #744 from HenryRLee:patch-1
PiperOrigin-RevId: 420781374
2 lat temu
Victor Costan
bda46dd00d
Merge pull request #602 from andyli029:feature_fix_lack_tag_comment
PiperOrigin-RevId: 420781095
2 lat temu
Victor Costan
ec4e3a5cb3
Merge pull request #747 from zltl:patch-1
PiperOrigin-RevId: 420778907
2 lat temu
Victor Costan
3ab94e7da8
Merge branch 'master' into fix_issue_505
2 lat temu
Victor Costan
3180f9cb40
Merge branch 'master' into patch-1
2 lat temu
Victor Costan
8ccb79b57e
Merge pull request #901 from mapleFU:opt-using-move
PiperOrigin-RevId: 420662938
2 lat temu
Victor Costan
74f0be238f
Merge pull request #897 from raynolmenezes:patch-1
PiperOrigin-RevId: 420662891
2 lat temu
Victor Costan
56f2394250
Merge pull request #945 from xiong-ang:master
PiperOrigin-RevId: 420645727
2 lat temu
Victor Costan
068a0f1214
Merge pull request #934 from BilyZ98:master
PiperOrigin-RevId: 420645080
2 lat temu
Victor Costan
8f5aa6375e
Merge pull request #919 from wineway:fix_posix_test
PiperOrigin-RevId: 420644954
2 lat temu
Victor Costan
7a2f90460a
Merge pull request #928 from ehds:fix-comment
PiperOrigin-RevId: 420541137
2 lat temu
Victor Costan
4db0eaccf1
Merge pull request #960 from ericuni:dedup
PiperOrigin-RevId: 420534594
2 lat temu
Victor Costan
7ee3889a61
VersionSet::Builder::Apply() does not mutate its argument.
PiperOrigin-RevId: 420533763
2 lat temu
Victor Costan
42cf899927
Merge pull request #903 from LazyWolfLin:dev_random
PiperOrigin-RevId: 420532625
2 lat temu
Victor Costan
8796c44772
Merge pull request #902 from ehds:update-table-cache
PiperOrigin-RevId: 420517390
2 lat temu
Victor Costan
e4ccaa0c9c
Merge pull request #965 from ShawnZhong:cpp20
PiperOrigin-RevId: 420504266
2 lat temu
Victor Costan
c8b708d496
Merge pull request #967 from rex4539:typos
PiperOrigin-RevId: 420403341
2 lat temu
Victor Costan
639195221c
Merge pull request #968 from xindubawukong:dxy_remove_code
PiperOrigin-RevId: 420399272
2 lat temu
xindubawukong
87b3a371b1
remove useless code in cache.h
2 lat temu
Dimitris Apostolou
0e8aa26c4e
Fix typos
2 lat temu
Victor Costan
8f464e7f68
Remove main() from most tests.
This gives some flexibility to embedders.
Currently, embedders have to build a binary for each test file.
After this CL, embedders can still choose to have a binary for each test
file, by linking each test file with a googletest target that includes
main() (usually "gtest_main"). Embedders can also choose to build a
single binary for almost all test files, and link with a googletest
target that includes main(). The latter is more convenient for projects
that have very few test binaries, like Chromium.
PiperOrigin-RevId: 419470798
2 lat temu
Shawn Zhong
7a2f64ed50
Update env_posix.cc
2 lat temu
Victor Costan
b2801ee1a0
Extract benchmark from db_test.cc.
The benchmark in db/db_test.cc is extracted to its own file,
benchmarks/db_bench_log.cc.
PiperOrigin-RevId: 418713499
2 lat temu
Victor Costan
335876a133
Add invariant checks to Limiter in Env implementations.
PiperOrigin-RevId: 417853172
2 lat temu
Eric Wang
42d00a80cc
rm redundant code: SetNextFile has already been called before in this function
3 lat temu
Victor Costan
e426c83e88
Merge pull request #941 from pmmp:no-handle-inheritance
PiperOrigin-RevId: 412997201
3 lat temu
Victor Costan
6124f47490
Merge pull request #951 from philix:no_pthread
PiperOrigin-RevId: 412965575
3 lat temu
Felipe Oliveira Carvalho
dd6658754f
Remove <pthread.h> include and find_package() from build files
3 lat temu
xiong-ang
d7da5d9d35
fix some trifling points
3 lat temu
Dylan K. Taylor
68d14a723a
Prevent handle used for LOG from being inherited by subprocesses
I recently encountered a problem with this because Windows doesn't allow
files to be deleted when there's open handles to them.
Other files opened by leveldb are not affected because by and large they
are using CreateFileA, which does not allow inheritance when
lpSecurityAttributes is null (ref:
https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilea )
However, fopen() _does_ allow inheritance, and it needs to be expressly
disabled.
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/fopen-wfopen?view=msvc-160
3 lat temu
leveldb Team
c5d5174a66
Get env_posix.cc building under Fuchsia.
PiperOrigin-RevId: 395824737
3 lat temu
zzt
11aafab31f
Fix version_set.cc comments typo
Fix typo of comment of FindLargestKey function
3 lat temu
Victor Costan
5783a79309
Switch CI to GitHub Actions.
PiperOrigin-RevId: 394542401
3 lat temu