소스 검색

Fix FD leak in POSIX Env.

Deleting a PosixWritableFile without calling Close() leaks the file
descriptor. While the API description in include/leveldb/env.h does not
specify whether the caller is responsible for Close()ing the file before
deleting it, all other Env file implementations do release underlying
resources when destroyed, even if Close() is not called.

The leak shows up when running db_tests on Mac Travis, or on a vanilla
MacOS install.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=170906843
master
costan 7 년 전
committed by Victor Costan
부모
커밋
8ae7998aab
1개의 변경된 파일1개의 추가작업 그리고 1개의 파일을 삭제
  1. +1
    -1
      util/env_posix.cc

+ 1
- 1
util/env_posix.cc 파일 보기

@ -230,7 +230,7 @@ class PosixWritableFile : public WritableFile {
~PosixWritableFile() {
if (fd_ >= 0) {
// Ignoring any potential errors
FlushBuffered();
Close();
}
}

불러오는 중...
취소
저장