Bladeren bron

Sync MANIFEST before closing in db_impl when creating a new DB.

Add logging with debugging information when failing to load a version set.

PiperOrigin-RevId: 351432332
main
leveldb Team 3 jaren geleden
committed by Victor Costan
bovenliggende
commit
8f1861462b
2 gewijzigde bestanden met toevoegingen van 11 en 0 verwijderingen
  1. +5
    -0
      db/db_impl.cc
  2. +6
    -0
      db/version_set.cc

+ 5
- 0
db/db_impl.cc Bestand weergeven

@ -197,6 +197,9 @@ Status DBImpl::NewDB() {
new_db.EncodeTo(&record);
s = log.AddRecord(record);
if (s.ok()) {
s = file->Sync();
}
if (s.ok()) {
s = file->Close();
}
}
@ -301,6 +304,8 @@ Status DBImpl::Recover(VersionEdit* edit, bool* save_manifest) {
if (!env_->FileExists(CurrentFileName(dbname_))) {
if (options_.create_if_missing) {
Log(options_.info_log, "Creating DB %s since it was missing.",
dbname_.c_str());
s = NewDB();
if (!s.ok()) {
return s;

+ 6
- 0
db/version_set.cc Bestand weergeven

@ -898,6 +898,7 @@ Status VersionSet::Recover(bool* save_manifest) {
uint64_t log_number = 0;
uint64_t prev_log_number = 0;
Builder builder(this, current_);
int read_records = 0;
{
LogReporter reporter;
@ -907,6 +908,7 @@ Status VersionSet::Recover(bool* save_manifest) {
Slice record;
std::string scratch;
while (reader.ReadRecord(&record, &scratch) && s.ok()) {
++read_records;
VersionEdit edit;
s = edit.DecodeFrom(record);
if (s.ok()) {
@ -981,6 +983,10 @@ Status VersionSet::Recover(bool* save_manifest) {
} else {
*save_manifest = true;
}
} else {
std::string error = s.ToString();
Log(options_->info_log, "Error recovering version set with %d records: %s",
read_records, error.c_str());
}
return s;

Laden…
Annuleren
Opslaan