#1 WIP: use value instead of new field to cover ttl, can run successfully without garbage collection

Sloučený
谢瑞阳 sloučil 1 revizí z větve new_version do větve master před před 3 týdny
  1. +25
    -1
      db/db_impl.cc
  2. +2
    -0
      db/db_impl.h
  3. +3
    -0
      db/db_test.cc
  4. +10
    -2
      db/memtable.cc
  5. +6
    -1
      db/version_set.cc
  6. +1
    -1
      include/leveldb/db.h
  7. +32
    -44
      test/ttl_test.cc

+ 25
- 1
db/db_impl.cc Zobrazit soubor

@ -1198,6 +1198,10 @@ Status DBImpl::Put(const WriteOptions& o, const Slice& key, const Slice& val) {
return DB::Put(o, key, val);
}
Status DBImpl::Put(const WriteOptions& o, const Slice& key, const Slice& val,uint64_t ttl) {
return DB::Put(o, key, val,ttl);
}
Status DBImpl::Delete(const WriteOptions& options, const Slice& key) {
return DB::Delete(options, key);
}
@ -1487,7 +1491,27 @@ void DBImpl::GetApproximateSizes(const Range* range, int n, uint64_t* sizes) {
// can call if they wish
Status DB::Put(const WriteOptions& opt, const Slice& key, const Slice& value) {
WriteBatch batch;
batch.Put(key, value);
int len=value.size()+sizeof(uint64_t);
char* new_data=new char[len];
time_t now = time(nullptr);//ttl单位为秒
uint64_t ttl=INT64_MAX;
memcpy(new_data,value.data(),value.size());
memcpy(new_data+len-sizeof(uint64_t),(char*)(&ttl),sizeof(uint64_t));
Slice newValue=Slice(new_data,len);
batch.Put(key, newValue);
return Write(opt, &batch);
}
Status DB::Put(const WriteOptions& opt, const Slice& key, const Slice& value,uint64_t ttl) {
WriteBatch batch;
int len=value.size()+sizeof(uint64_t);
char* new_data=new char[len];
time_t now = time(nullptr);//ttl单位为秒
ttl+=static_cast<uint64_t>(now);
memcpy(new_data,value.data(),value.size());
memcpy(new_data+len-sizeof(uint64_t),(char*)(&ttl),sizeof(uint64_t));
Slice newValue=Slice(new_data,len);
batch.Put(key, newValue);
return Write(opt, &batch);
}

+ 2
- 0
db/db_impl.h Zobrazit soubor

@ -38,6 +38,8 @@ class DBImpl : public DB {
// Implementations of the DB interface
Status Put(const WriteOptions&, const Slice& key,
const Slice& value) override;
Status Put(const WriteOptions&, const Slice& key,
const Slice& value,uint64_t ttl) override;
Status Delete(const WriteOptions&, const Slice& key) override;
Status Write(const WriteOptions& options, WriteBatch* updates) override;
Status Get(const ReadOptions& options, const Slice& key,

+ 3
- 0
db/db_test.cc Zobrazit soubor

@ -2117,6 +2117,9 @@ class ModelDB : public DB {
Status Put(const WriteOptions& o, const Slice& k, const Slice& v) override {
return DB::Put(o, k, v);
}
Status Put(const WriteOptions& o, const Slice& k, const Slice& v,uint64_t ttl) override {
return DB::Put(o, k, v,ttl);
}
Status Delete(const WriteOptions& o, const Slice& key) override {
return DB::Delete(o, key);
}

+ 10
- 2
db/memtable.cc Zobrazit soubor

@ -103,7 +103,7 @@ bool MemTable::Get(const LookupKey& key, std::string* value, Status* s) {
Slice memkey = key.memtable_key();
Table::Iterator iter(&table_);
iter.Seek(memkey.data());
if (iter.Valid()) {
while (iter.Valid()) {
// entry format is:
// klength varint32
// userkey char[klength]
@ -123,7 +123,14 @@ bool MemTable::Get(const LookupKey& key, std::string* value, Status* s) {
switch (static_cast<ValueType>(tag & 0xff)) {
case kTypeValue: {
Slice v = GetLengthPrefixedSlice(key_ptr + key_length);
value->assign(v.data(), v.size());
uint64_t ttl=*(uint64_t*)(v.data()+v.size()-sizeof(uint64_t));
time_t now = time(nullptr);
if(ttl < static_cast<uint64_t>(now)){
iter.Next();
continue;
}
value->assign(v.data(), v.size()-sizeof(uint64_t));
return true;
}
case kTypeDeletion:
@ -131,6 +138,7 @@ bool MemTable::Get(const LookupKey& key, std::string* value, Status* s) {
return true;
}
}
else break;
}
return false;
}

+ 6
- 1
db/version_set.cc Zobrazit soubor

@ -266,9 +266,14 @@ static void SaveValue(void* arg, const Slice& ikey, const Slice& v) {
s->state = kCorrupt;
} else {
if (s->ucmp->Compare(parsed_key.user_key, s->user_key) == 0) {
if(parsed_key.type == kTypeValue){
time_t now = time(nullptr);
uint64_t ttl=*(uint64_t*)(v.data()+v.size()-8);
if(ttl < static_cast<uint64_t>(now))return;
}
s->state = (parsed_key.type == kTypeValue) ? kFound : kDeleted;
if (s->state == kFound) {
s->value->assign(v.data(), v.size());
s->value->assign(v.data(), v.size()-8);
}
}
}

+ 1
- 1
include/leveldb/db.h Zobrazit soubor

@ -149,7 +149,7 @@ class LEVELDB_EXPORT DB {
// ----------------------------For TTL-----------------------------
// key设置ttl
virtual Status Put(const WriteOptions& options, const Slice& key,
const Slice& value, uint64_t ttl) = 0;
const Slice& value, uint64_t ttl)=0;
};
// Destroy the contents of the specified database.

+ 32
- 44
test/ttl_test.cc Zobrazit soubor

@ -20,30 +20,15 @@ Status OpenDB(std::string dbName, DB **db) {
void InsertData(DB *db, uint64_t ttl/* second */) {
WriteOptions writeOptions;
int key_num = data_size / value_size;
srand(static_cast<unsigned int>(time(0)));
for (int i = 0; i < key_num; i++) {
int key_ = rand() % key_num+1;
for (int i = 0; i < 100000; i++) {
int key_ = i;
std::string key = std::to_string(key_);
std::string value(value_size, 'a');
db->Put(writeOptions, key, value, ttl);
}
}
void GetData(DB *db, int size = (1 << 30)) {
ReadOptions readOptions;
int key_num = data_size / value_size;
// 点查
srand(static_cast<unsigned int>(time(0)));
for (int i = 0; i < 100; i++) {
int key_ = rand() % key_num+1;
std::string key = std::to_string(key_);
std::string value;
db->Get(readOptions, key, &value);
}
}
TEST(TestTTL, ReadTTL) {
DB *db;
if(OpenDB("testdb", &db).ok() == false) {
@ -51,7 +36,7 @@ TEST(TestTTL, ReadTTL) {
abort();
}
uint64_t ttl = 20;
uint64_t ttl = 10;
InsertData(db, ttl);
@ -59,52 +44,55 @@ TEST(TestTTL, ReadTTL) {
Status status;
int key_num = data_size / value_size;
srand(static_cast<unsigned int>(time(0)));
for (int i = 0; i < 100; i++) {
int key_ = rand() % key_num+1;
for (int i = 0; i < 100000; i++) {
int key_ = i;
std::string key = std::to_string(key_);
std::string value;
status = db->Get(readOptions, key, &value);
ASSERT_TRUE(status.ok());
}
Env::Default()->SleepForMicroseconds(ttl * 1000000);
Env::Default()->SleepForMicroseconds((ttl+5) * 1000000);
for (int i = 0; i < 100; i++) {
int key_ = rand() % key_num+1;
for (int i = 0; i < 100000; i++) {
int key_ = i;
std::string key = std::to_string(key_);
std::string value;
status = db->Get(readOptions, key, &value);
if(status.ok()){
std::cout<<"!!";
}
ASSERT_FALSE(status.ok());
}
}
TEST(TestTTL, CompactionTTL) {
DB *db;
// TEST(TestTTL, CompactionTTL) {
// DB *db;
if(OpenDB("testdb", &db).ok() == false) {
std::cerr << "open db failed" << std::endl;
abort();
}
// if(OpenDB("testdb", &db).ok() == false) {
// std::cerr << "open db failed" << std::endl;
// abort();
// }
uint64_t ttl = 20;
InsertData(db, ttl);
// uint64_t ttl = 20;
// InsertData(db, ttl);
leveldb::Range ranges[1];
ranges[0] = leveldb::Range("-", "A");
uint64_t sizes[1];
db->GetApproximateSizes(ranges, 1, sizes);
ASSERT_GT(sizes[0], 0);
// leveldb::Range ranges[1];
// ranges[0] = leveldb::Range("-", "A");
// uint64_t sizes[1];
// db->GetApproximateSizes(ranges, 1, sizes);
// ASSERT_GT(sizes[0], 0);
Env::Default()->SleepForMicroseconds(ttl * 1000000);
// Env::Default()->SleepForMicroseconds(ttl * 1000000);
db->CompactRange(nullptr, nullptr);
// db->CompactRange(nullptr, nullptr);
leveldb::Range ranges[1];
ranges[0] = leveldb::Range("-", "A");
uint64_t sizes[1];
db->GetApproximateSizes(ranges, 1, sizes);
ASSERT_EQ(sizes[0], 0);
}
// leveldb::Range ranges[1];
// ranges[0] = leveldb::Range("-", "A");
// uint64_t sizes[1];
// db->GetApproximateSizes(ranges, 1, sizes);
// ASSERT_EQ(sizes[0], 0);
// }
int main(int argc, char** argv) {

Načítá se…
Zrušit
Uložit