You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

41 lines
2.0 KiB

2 years ago
  1. # How-to contribute
  2. Those are the main contributing guidelines for contributing to this project:
  3. - Verify that your contribution does not embark proprietary code or infringe any copyright of any sort.
  4. - Avoid adding any unnecessary dependencies to the project, espcially of those are not easily packaged and installed through `conda` or `pip`.
  5. - Python contributions must follow the [PEP 8 style guide](https://www.python.org/dev/peps/pep-0008/).
  6. - Use [Pull Request](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests) mechanism and please be patient while waiting for reviews.
  7. - Remain polite and civil in all exchanges with the maintainers and other contributors.
  8. - Any issue submitted which does not respect provided template, or lack of information, will be considered as invalid and automatically closed.
  9. ## Get started
  10. This project is managed using [Poetry](https://python-poetry.org/docs/basic-usage/),
  11. in order to contribute, the safest is to create your
  12. [own fork of spleeter](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) first and then setup your development environment:
  13. ```bash
  14. # Clone spleeter repository fork
  15. git clone https://github.com/<your_name>/spleeter && cd spleeter
  16. # Install poetry
  17. pip install poetry
  18. # Install spleeter dependencies
  19. poetry install
  20. # Run unit test suite
  21. poetry run pytest tests/
  22. ```
  23. You can then make your changes and experiment freely. Once you're done, remember to check that the tests still run. If you've added a new feature, add tests!
  24. Then finally, you're more than welcome to create a [Pull Request](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork) in **Spleeter** main repo. We will look at it as soon as possible and eventually integrate your changes in the project.
  25. ## PR requirements
  26. Following command should be ran successfully before to consider a PR for merging:
  27. ```bash
  28. poetry run pytest tests/
  29. poetry run black spleeter
  30. poetry run isort spleeter
  31. ```